Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SamsungTV Mac validation #21268

Merged
merged 1 commit into from Feb 21, 2019
Merged

Add SamsungTV Mac validation #21268

merged 1 commit into from Feb 21, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Feb 21, 2019

Description:

Related issue (if applicable): fixes #21263

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned balloob Feb 21, 2019
@ghost ghost added the in progress label Feb 21, 2019
@balloob balloob added this to the 0.88.1 milestone Feb 21, 2019
@balloob balloob merged commit 4c4317f into dev Feb 21, 2019
@ghost ghost removed the in progress label Feb 21, 2019
@delete-merged-branch delete-merged-branch bot deleted the add-samsungtv-mac branch February 21, 2019 16:52
balloob added a commit that referenced this pull request Feb 22, 2019
@balloob balloob mentioned this pull request Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Samsung TV mac key incorrectly throwing warning
2 participants